掲示板 Forums - Vacation Feature Bug
Top > renshuu.org > Bugs / Problems Getting the posts
Top > renshuu.org > Bugs / Problems
I set saturday to my vacation, so that it does not give me new terms or reviews, but it still gives me reviews on Saturday despite setting Saturday to vacation.
Thanks - I will need a lot more info to be able to look into this.
Even if you have the issue happening for multiple schedules, a specific list of one or two schedules with the issue will help.
Did you fully clear all the reviews you had on Friday? When did you turn the holiday setting on?
I had all my reviews cleared through on Friday. It happened to all of my schedules. One of my schedules is one where I merged Japanese Basics words with Japanese Beginner words, same thing for the grammar schedules. I also have N4+N5 kanji, and a schedule for N3 kanji.
I turned the holiday setting on Saturday two weeks ago. It did not clear the terms that day even though I clicked the option to do so. Then the next Saturday I still had reviews. All my lists are set to review.
Thanks. This may take awhile to squash, but I'm sure we'll get to it.
This is what I'd like you to do (and in advance, just want to say I really appreciate your cooperation)
1. Question: do the reviews that appeared on Saturday appear to be about the same as your usual reviews, or a much smaller fraction?
2. Next time it happens, please quiz one of the schedules, and note 3-5 of the terms that came up. Please:
2a. Tell me which terms they were
2b. If you recall anything about the last time you interacted with them, please note that. If you do not recall, that's also ok.
Thank you so much!
Awesome, I'm more than happy to do all of that. I'll get back to you on Saturday. Thank you so much!



The last image is Saturday. It seems that it's quizzing me roughly the same amount. Although I notice that Pre-intermediate now says 0, and this is the one schedule I changed to learn instead of review this week. It's never been 0. Verb conjugation is also 0 interestingly.
Could it be that review mode on a schedule overrides vacation mode?
I'll post about 3-5 terms next.
I quizzed my Kanji N3-N4 schedule. The five terms I got are below. (Included picture so you could also see the multiple choice options, in case that helps, sorry about them not being cropped).





i don't really remember the last time I interacted with them, but they are all kanji that I recognize immediately and out of my schedule are probably some of the ones I have always had the easiest time recalling. AKA it only gave me "easy" kanji.
Let me know if there's anything else I can do to help!
Thank you. I do appreciate it, but no need to post screenshots next time - just the term (kanji) is fine :)
Ok, let's drill into one of these: 前. That day, you studied onyomi. 5 days earlier, you studied the definition for it (and got it correct).
Now, the date for the onyomi study (the one on the holiday) was NOT processed through the holiday system, which is most likely the issue. The hard part is figuring out what could have affected it. When you study a vector for a term (in this case, the definition), it does consider shifting the other vectors (like onyomi) in case they are being studied too close together. While this system should be passing through the holiday checks, perhaps there is a bug in the logic. I cannot see it, but that hasn't stopped bugs in the past!
I am going to continue to look at it, but I don't quite have all of the info I need yet. Please re-report the next time you see it. If it's just the kanji schedule, then a simple list of the affected kanji characters will work out just fine :)
Unfortunately, this new logging will only catch them if they are miscalculated after now (as I just put the logging code in), but will not catch them if they were got the wrong schedule dates earlier than now.
I think most of my schedules are affected. Should I send terms from each one next time?
My suspicion is that there is a *single* bug affecting all of them in the same way. So having a ton of reports will probably not help me. I'll happily take 2-3 examples from a single schedule.
Today only my words for japanese basics/beginner merged schedule had terms. Below is the list of some affected terms. Let me know if there is anything else I can do to help.
八つ
字引
明るい
20歳
Here is a larger (but not full) list of the terms that came up for review

Now, I've only drilled down on one of these (each one takes quite a bit of time to look through all the relevant data), but I did find something very interesting with 字引. It was NOT scheduled for your holiday. When you studied it on the holiday (Saturday), it showed the review date for it, and it was one day earlier (your Friday)!
The data (at least), suggests that there were reviews you did not get finished on Friday. Looking at the merge schedule's log data, I see this: (I'll try to explain what you're looking at)

"data stamp" is the internal counter for days. 7236 (the highlighted one) is your Saturday. (please ignore all the ones above the line with the highlighted number - those are future ones, and the data_stamp will get updated when those days roll around.)
"Upcoming goal" is your reviews for that day, and "upcoming_goal_left" is the number you didn't (or haven't) done for that day.
Looking at the 6 days prior to your 7236 holiday, 5 of the days (Sunday through Thursday), you have cleared out every review for your merged schedule.
On Friday, though, you have 153 terms for review, and 53 of them did not get reviewed that day. Those got carried over to the next day (your holiday).
Is it at all possible that you didn't get around to some of the reviews in your merged schedule on Friday?
It is possible I forgot to clear out my reviews on Friday. I remember intending to finish them after a meeting, but I also remembered the meeting going longer than normal which may have interrupted my ability to remember to finish those reviews. Now I am unsure how many times that has happened in the previous weeks. Although I am sure that originally I was not forgetting to do several schedules worth of reviews. On Fridays I usually only have one or two schedules that I cannot fully finish before work, usually intending to finish them after that meeting.
Thanks for the reply. I suspect that is/was the cause.
That being said, I think we've got an interesting situation here that can be improved. You, as a user, presumably do not want reviews on your holidays, perhaps EVEN if you did not finish reviews on the previous day.
So..what I could do is add one more checkbox on that page which would basically do this: if you have reviews on a holiday that were from a previous day (but not finished), shift them over to the next non-holiday.
What do you think?